-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data/libvirt: Drop local.hostnames #607
data/libvirt: Drop local.hostnames #607
Conversation
We used to assign both {name}-api and {name}-tnc to the bootstrap and master nodes. But we dropped {name}-tnc in 239373f (aws/ELBs: merge tnc with api_internal and cleanup, 2018-09-19, openshift#242). Now that it's just the one entry, the local.hostnames indirection is unecessary complication.
Dunno what's going on with all the CI errors. gofmt has:
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
We used to assign both
{name}-api
and{name}-tnc
to the bootstrap and master nodes. But we dropped{name}-tnc
in 239373f (#242). Now that it's just the one entry, thelocal.hostnames
indirection is unecessary complication.